feat: introduce automatic registration of --no-headers on list commands and cloud-provider list to use it#109
Open
Davidonium wants to merge 7 commits intomainfrom
Open
feat: introduce automatic registration of --no-headers on list commands and cloud-provider list to use it#109Davidonium wants to merge 7 commits intomainfrom
Davidonium wants to merge 7 commits intomainfrom
Conversation
…ds and cloud-provider list to use it
JustAwesomeGuy
previously approved these changes
Apr 8, 2026
JustAwesomeGuy
left a comment
JustAwesomeGuy
left a comment
There was a problem hiding this comment.
Added a small comment, otherwise lgtm!
| r.Render() | ||
| return nil | ||
| } | ||
| return lc.PrintText(cmd, cmd.OutOrStdout(), resp) |
There was a problem hiding this comment.
Does it make sense to return error here when both OutputTable and PrintText are not set?
Collaborator
Author
There was a problem hiding this comment.
It does, the code should panic since it's a development mistake. Adding it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this the rest of the list commands will be migrated to use
OutputTable.For now only the
cloud-provider listcommand has been modified. In further PRs, the rest of the list commands will be migrated to use OutputTable.